Rewrite CSV conversion to dodge Serde #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145.
After filing a bug on the csv crate (BurntSushi/rust-csv#151) it became pretty clear that there isn't really a way for Serde to losslessly decode the localization format Roblox expects for me.
This PR rewrites the CSV parser to manually trawl each record and map them into structs. I added a new regression test for #145 and made sure all existing tests continued to pass.